Canvas & GL small refactoring#6260
Merged
redawl merged 4 commits intofyne-io:developfrom Apr 11, 2026
Merged
Conversation
Contributor
|
Is there any background to why these changes are being made? I see more changes here than what is mentioned in the PR description as well. |
redawl
reviewed
Apr 9, 2026
redawl
approved these changes
Apr 10, 2026
Contributor
redawl
left a comment
There was a problem hiding this comment.
Looks good, thanks for the cleanup in the gl caching as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
canvas.ArbitraryPolygonVerticesMaximum(it is only needed internally)gl_core, gl_es, gl_gomobile, and gl_wasmpreviously included identical parameters for each shader, which were initialized during setup and remained immutable. I have removed these fixed parameters, allowingSetUniform*functions to create uniforms dynamically on the first call and cache them. Consequently, there is no longer a need to maintain lists of shader attributes, as the cache is automatically initialized bydraw*functions during first object creationUniform2fvfunction along with cacheChecklist: